[HUDI-6548] Two log compaction instants can be scheduled at the same time #9246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
reviewed
Jul 21, 2023
| */ | ||
| public HoodieTimeline getCommitsAndCompactionTimeline() { | ||
| return getTimelineOfActions(CollectionUtils.createSet(COMMIT_ACTION, DELTA_COMMIT_ACTION, REPLACE_COMMIT_ACTION, COMPACTION_ACTION)); | ||
| return getTimelineOfActions(CollectionUtils.createSet(COMMIT_ACTION, DELTA_COMMIT_ACTION, REPLACE_COMMIT_ACTION, COMPACTION_ACTION, LOG_COMPACTION_ACTION)); |
Contributor
There was a problem hiding this comment.
we should not fix this method. we should probably introduce
getCompletedCommitsCompactionLogCompactionTimeline
Collaborator
Author
There was a problem hiding this comment.
@nsivabalan This was added as part of #9038. Seems like this API should also consider inflight logcompaction. I have removed it from this PR but if it makes sense I will create a separate PR for it.
Collaborator
Collaborator
Author
|
The APIs will be refactored in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Few HoodieDefaultTimeline APIs are missing the log compaction filter. As a result the log compaction instants are not included as part of write client timeline which makes it possible to schedule two log compactions at the same time.
Impact
It fixes the HoodieDefaultTimeline APIs to include log compaction instants.
Risk level (write none, low medium or high below)
low
Documentation Update
NA
Contributor's checklist